[ML] Fix solution for preventing race conditions between timeout and completion #10740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…completion - solution was added in apache#4455
merlimat
approved these changes
May 28, 2021
eolivelli
reviewed
May 28, 2021
eolivelli
reviewed
May 28, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
May 29, 2021
…completion (apache#10740) - solution was added in apache#4455
wangjialing218
pushed a commit
to wangjialing218/pulsar
that referenced
this pull request
May 31, 2021
…completion (apache#10740) - solution was added in apache#4455
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2021
…completion (apache#10740) - solution was added in apache#4455 (cherry picked from commit 4372b49)
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…completion (apache#10740) - solution was added in apache#4455
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…completion (apache#10740) - solution was added in apache#4455
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It seem that the solution for preventing race conditions between timeout and completion doesn't work.
The repro case in #10738 can reproduce this problem.
Modifications
This small modification:
ADD_OP_COUNT_UPDATER.compareAndSet(this, this.addOpCount, -1)->ADD_OP_COUNT_UPDATER.compareAndSet(this, addOpCount, -1).It seems that passing
this.addOpCountto the second argument wouldn't make sense. The method also contains aaddOpCountvariable which is unused. Therefore it seems that the actual intention has been to use theaddOpCountlocal variable instead of theaddOpCountfield.Additional context
Original solution was added in #4455.