Move zookeeper/bookkeeper from dependency management and only specify the dependency when they are used #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the dependency when they are used
|
fyi - this is a temporary change to allow me using the latest apache/bookkeeper version in a new module I am working on for pulsar. I created a follow up issue #1053 for moving zk/bk back to dependency management after pulsar starts using latest apache/bookkeeper version. |
|
I am not sure if this is a good idea to move it out from dependency-management for development testing. and for dev testing, can't we always override maven-version into specific module's pom.? |
|
@rdhabalia I tried with override version. it didn't work, because it seems that dependency management enforces version selection even the dependency is a transitive dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently zookeeper and bookkeeper are specified in dependency management. so a specific version of zookeeper and bookkeeper is enforced across the project. It would be good to move zk and bk away from dependency management and only specify the dependency when they are used. so it allows playing around with the new bookkeeper version in a separate module.
Modifications
Result
It allows me using the latest bookkeeper client in a separated module that I am working on.