Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Add setter for reader subscription name #10027

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

Jennifer88huang-zz
Copy link
Contributor

Master Issue: #8787
Related PR: #8801

Modifications

Add doc content on adding setter for reader subscription name.

@Jennifer88huang-zz Jennifer88huang-zz self-assigned this Mar 24, 2021
@Jennifer88huang-zz Jennifer88huang-zz added area/client doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels Mar 24, 2021
@Jennifer88huang-zz Jennifer88huang-zz added this to the 2.8.0 milestone Mar 24, 2021
@Anonymitaet
Copy link
Member

@jennifer88huang thanks for your contribution. Need to add similar contents for C++ client as well?

@@ -675,6 +676,7 @@ String|`topicName`|Topic name. |None
int|`receiverQueueSize`|Size of a consumer's receiver queue.<br/><br/>For example, the number of messages that can be accumulated by a consumer before an application calls `Receive`.<br/><br/>A value higher than the default value increases consumer throughput, though at the expense of more memory utilization.|1000
ReaderListener&lt;T&gt;|`readerListener`|A listener that is called for message received.|None
String|`readerName`|Read name.|null
String| `subscriptionName`|Subscription name|None
Copy link
Contributor

@315157973 315157973 Mar 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value is not None
When there is a single topic, the default subscription name is: "reader-" + 10-digit UUID
When there are multiple topics, the default subscription name is: "multiTopicsReader-" + 10-digit UUID

Copy link
Contributor Author

@Jennifer88huang-zz Jennifer88huang-zz Mar 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your comment. Updated, ptal again.

@Jennifer88huang-zz
Copy link
Contributor Author

@jennifer88huang thanks for your contribution. Need to add similar contents for C++ client as well?

Currently, we do not have any content related to Reader for C++ client. We can add it when improving C++ client as a whole. You can add a follow-up issue for it.

@Jennifer88huang-zz Jennifer88huang-zz merged commit 9559114 into apache:master Mar 26, 2021
@Jennifer88huang-zz Jennifer88huang-zz deleted the reader branch March 26, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants