code quality issue: pulsar 2.7.0 check style issue. don't we run check style before we release it？？

[xiaotongwang1]

1、i download the source code of pulsar release version 2.7.0 ,nothing change !!!!!!!
2、i use the command mvn install -Pcore-modules -DskipTests

output some check style error:

[INFO] There are 17 errors reported by Checkstyle 8.37 with ../buildtools/src/main/resources/pulsar/checkstyle.xml ruleset.
[ERROR] src\main\java\org\apache\pulsar\client\api\Authentication.java:[28,1] (imports) ImportOrder: 导入组之前的额外空行 'org.apache.pulsar.client.api.PulsarClientException.UnsupportedAuthenticationException'。
[ERROR] src\main\java\org\apache\pulsar\client\api\AuthenticationDataProvider.java:[23,1] (imports) ImportOrder: 导入组之前的额外空行 'java.io.InputStream'。
[ERROR] src\main\java\org\apache\pulsar\client\api\AuthenticationDataProvider.java:[30,1] (imports) ImportOrder: 导入组之前的额外空行 'javax.naming.AuthenticationException'。
[ERROR] src\main\java\org\apache\pulsar\client\api\AuthenticationDataProvider.java:[32,1] (imports) ImportOrder: 导入组之前的额外空行 'org.apache.pulsar.common.api.AuthData'。
[ERROR] src\main\java\org\apache\pulsar\client\api\AuthenticationFactory.java:[24,1] (imports) ImportOrder: 导入组之前的额外空行 'org.apache.pulsar.client.api.PulsarClientException.UnsupportedAuthenticationException'。
[ERROR] src\main\java\org\apache\pulsar\client\api\ConsumerStats.java:[24,1] (imports) ImportOrder: 导入组之前的额外空行 'org.apache.pulsar.common.classification.InterfaceAudience'。
[ERROR] src\main\java\org\apache\pulsar\client\api\MessageId.java:[24,1] (imports) ImportOrder: 导入组之前的额外空行 'org.apache.pulsar.client.internal.DefaultImplementation'。
[ERROR] src\main\java\org\apache\pulsar\client\api\PulsarClient.java:[25,1] (imports) ImportOrder: 导入组之前的额外空行 'org.apache.pulsar.client.api.transaction.TransactionBuilder'。
[ERROR] src\main\java\org\apache\pulsar\client\api\schema\SchemaDefinition.java:[24,1] (imports) ImportOrder: 导入组之前的额外空行 'org.apache.pulsar.client.internal.DefaultImplementation'。
[ERROR] src\main\java\org\apache\pulsar\client\api\transaction\TxnID.java:[24,1] (imports) ImportOrder: 导入组之前的额外空行 'lombok.Data'。
[ERROR] src\main\java\org\apache\pulsar\client\internal\DefaultImplementation.java:[26,1] (imports) ImportOrder: 导入组之前的额外空行 'java.lang.reflect.Constructor'。
[ERROR] src\main\java\org\apache\pulsar\client\internal\ReflectionUtils.java:[25,1] (imports) ImportOrder: 导入组之前的额外空行 'lombok.experimental.UtilityClass'。
[ERROR] src\main\java\org\apache\pulsar\common\api\AuthData.java:[23,1] (imports) ImportOrder: 导入组之前的额外空行 'lombok.Data'。
[ERROR] src\main\java\org\apache\pulsar\common\api\EncryptionContext.java:[24,1] (imports) ImportOrder: 导入组之前的额外空行 'lombok.AllArgsConstructor'。
[ERROR] src\main\java\org\apache\pulsar\common\api\EncryptionContext.java:[29,1] (imports) ImportOrder: 导入组之前的额外空行 'org.apache.pulsar.client.api.CompressionType'。
[ERROR] src\main\java\org\apache\pulsar\common\schema\SchemaInfo.java:[23,1] (imports) ImportOrder: 导入组之前的额外空行 'java.util.Base64'。
[ERROR] src\main\java\org\apache\pulsar\common\schema\SchemaInfo.java:[27,1] (imports) ImportOrder: 导入组之前的额外空行 'lombok.AllArgsConstructor'。
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Pulsar 2.7.0:
[INFO]
[INFO] Pulsar Build Tools ................................. SUCCESS [ 4.403 s]
[INFO] Pulsar ............................................. SUCCESS [ 2.985 s]
[INFO] Pulsar Test Mocks .................................. SUCCESS [ 2.504 s]
[INFO] Pulsar Client :: API ............................... FAILURE [ 47.935 s]

[sijie]

@yanshuchong Pulsar doesn't enable checkstyle plugin for all modules. There is an ongrowing effort in the community to enable checkstyle across all the modules. See https://github.com/streamnative/pulsar/issues/1760 The effort started in the late stage of 2.7.0 development. It hasn't completed.

Have you tried mvn clean install -DskipTests without any profiles? core-modules profile is used in CI to accelerating the CI pipeline. It is possible that we misconfigure checkstyle plugin in core-modules to run checkstyle over the modules that haven't updated to conform the checkstyle rules.

[xiaotongwang1]

mvn -T 1C clean install -Pcore-modules -DskipTests -Dcheckstyle.skip=true --fail-at-end

i try to use -Dcheckstyle.skip=true to skip code style check

[sijie]

have you tried run mvn clean install -DskipTests? This is the command we used for release builds.

[BewareMyPower]

@sijie It looks like a bug of checkstyle plugin on Windows that Union Pay's user has met before. The checkstyle plugin has different behavior on Windows that it doesn't allow blank lines between two import sentences.

@yanshuchong Did you build pulsar on Windows?

[xiaotongwang1]

yes ，on Windows

[BewareMyPower]

It's better to build pulsar on Linux or MacOS since there're already related CI checks.

By the way, I tried to fix the build error on Windows yesterday and found the build error seems to be already fixed, i.e. I could build latest pulsar on Windows but failed with 2.7.0.

[codelipenghui]

The issue had no activity for 30 days, mark with Stale label.

[tisonkun]

I believe we're now running Checkstyle always: #18142