[refactor] Replace C-style array declaration with Java-style (#16525)

apache · Jul 13, 2022 · 8d1fb17 · 8d1fb17
1 parent 0dee92d
commit 8d1fb17
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneStarter.java b/pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneStarter.java
@@ -121,7 +121,7 @@ private static boolean argsContains(String[] args, String arg) {
         return Arrays.asList(args).contains(arg);
     }
 
-    public static void main(String args[]) throws Exception {
+    public static void main(String[] args) throws Exception {
         // Start standalone
         PulsarStandaloneStarter standalone = new PulsarStandaloneStarter(args);
         try {

diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/PulsarVersionStarter.java b/pulsar-broker/src/main/java/org/apache/pulsar/PulsarVersionStarter.java
@@ -35,7 +35,7 @@ private static class Arguments {
         private boolean generateDocs = false;
     }
 
-    public static void main(String args[]) {
+    public static void main(String[] args) {
         Arguments arguments = new Arguments();
         JCommander jcommander = new JCommander();
         try {

diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/StandaloneTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/StandaloneTest.java
@@ -41,7 +41,7 @@ protected void cleanup() throws Exception {
 
     @Test
     public void testWithoutMetadataStoreUrlInConfFile() throws Exception {
-        String args[] = new String[]{"--config",
+        String[] args = new String[]{"--config",
                 "../conf/standalone.conf"};
         PulsarStandaloneStarter standalone = new PulsarStandaloneStarter(args);
         assertNotNull(standalone.getConfig().getProperties().getProperty("metadataStoreUrl"));
@@ -50,7 +50,7 @@ public void testWithoutMetadataStoreUrlInConfFile() throws Exception {
 
     @Test
     public void testAdvertised() throws Exception {
-        String args[] = new String[]{"--config",
+        String[] args = new String[]{"--config",
                 "./src/test/resources/configurations/pulsar_broker_test_standalone.conf"};
         PulsarStandaloneStarter standalone = new PulsarStandaloneStarter(args);
         assertNull(standalone.getConfig().getAdvertisedAddress());

diff --git a/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/TestZKServer.java b/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/TestZKServer.java
@@ -162,7 +162,7 @@ public String getConnectionString() {
 
     public static boolean waitForServerUp(String hp, long timeout) {
         long start = System.currentTimeMillis();
-        String split[] = hp.split(":");
+        String[] split = hp.split(":");
         String host = split[0];
         int port = Integer.parseInt(split[1]);
         while (true) {

diff --git a/...-websocket/src/main/java/org/apache/pulsar/websocket/service/WebSocketServiceStarter.java b/...-websocket/src/main/java/org/apache/pulsar/websocket/service/WebSocketServiceStarter.java
@@ -49,7 +49,7 @@ private static class Arguments {
         private boolean generateDocs = false;
     }
 
-    public static void main(String args[]) throws Exception {
+    public static void main(String[] args) throws Exception {
         Arguments arguments = new Arguments();
         JCommander jcommander = new JCommander();
         try {