inverse createdLookupPinnedExecutor and fix constructor

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
apache · Oct 14, 2024 · 2d02348 · 2d02348
1 parent 179f950
commit 2d02348
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/BinaryProtoLookupService.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/BinaryProtoLookupService.java
@@ -129,11 +129,11 @@ public BinaryProtoLookupService(PulsarClientImpl client,
         histoListTopics = histo.withAttributes(Attributes.builder().put("pulsar.lookup.type", "list-topics").build());
 
         if (lookupPinnedExecutor == null) {
-            this.createdLookupPinnedExecutor = false;
+            this.createdLookupPinnedExecutor = true;
             this.lookupPinnedExecutor =
                     Executors.newSingleThreadExecutor(new DefaultThreadFactory("pulsar-client-binary-proto-lookup"));
         } else {
-            this.createdLookupPinnedExecutor = true;
+            this.createdLookupPinnedExecutor = false;
             this.lookupPinnedExecutor = lookupPinnedExecutor;
         }
     }
@@ -461,7 +461,7 @@ private void getTopicsUnderNamespace(InetSocketAddress socketAddress,
 
     @Override
     public void close() throws Exception {
-        if (!createdLookupPinnedExecutor && lookupPinnedExecutor != null && !lookupPinnedExecutor.isShutdown()) {
+        if (createdLookupPinnedExecutor && lookupPinnedExecutor != null && !lookupPinnedExecutor.isShutdown()) {
             lookupPinnedExecutor.shutdown();
         }
     }

diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
@@ -183,6 +183,15 @@ public PulsarClientImpl(ClientConfigurationData conf, EventLoopGroup eventLoopGr
         this(conf, eventLoopGroup, cnxPool, timer, null, null, null, null);
     }
 
+    public PulsarClientImpl(ClientConfigurationData conf, EventLoopGroup eventLoopGroup, ConnectionPool connectionPool,
+                            Timer timer, ExecutorProvider externalExecutorProvider,
+                            ExecutorProvider internalExecutorProvider,
+                            ScheduledExecutorProvider scheduledExecutorProvider)
+            throws PulsarClientException {
+        this(conf, eventLoopGroup, connectionPool, timer, externalExecutorProvider, internalExecutorProvider,
+                scheduledExecutorProvider, null);
+    }
+
     @Builder(builderClassName = "PulsarClientImplBuilder")
     private PulsarClientImpl(ClientConfigurationData conf, EventLoopGroup eventLoopGroup, ConnectionPool connectionPool,
                              Timer timer, ExecutorProvider externalExecutorProvider,