Skip to content

Commit

Permalink
Update delete inactive topic configuration documentation (#12350)
Browse files Browse the repository at this point in the history
### Motivation
When users turn on brokerDeleteInactiveTopics and turn off allowAutoTopicCreation, the broker will delete some inactive partitions of the topic and can't be created when new producers and consumers connected to it. It will make users confused.

In fact, the brokerDeleteInactiveTopicsEnabled need to cooperate with allowAutoTopicCreation parameters. If brokerDeleteInactiveTopicsEnabled is set to true, we should ensure that allowAutoTopicCreation is also set to true.

### Modification
Add some comments for brokerDeleteInactiveTopicsEnabled parameter to clarify its usage.
  • Loading branch information
hangc0276 authored Oct 14, 2021
1 parent 3a337b8 commit 09e5a86
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion conf/broker.conf
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ allowAutoSubscriptionCreation=true
# The number of partitioned topics that is allowed to be automatically created if allowAutoTopicCreationType is partitioned.
defaultNumPartitions=1

# Enable the deletion of inactive topics
# Enable the deletion of inactive topics. This parameter need to cooperate with the allowAutoTopicCreation parameter.
# If brokerDeleteInactiveTopicsEnabled is set to true, we should ensure that allowAutoTopicCreation is also set to true.
brokerDeleteInactiveTopicsEnabled=true

# How often to check for inactive topics
Expand Down
3 changes: 2 additions & 1 deletion conf/standalone.conf
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ backlogQuotaDefaultLimitSecond=-1
# Default ttl for namespaces if ttl is not already configured at namespace policies. (disable default-ttl with value 0)
ttlDurationDefaultInSeconds=0

# Enable the deletion of inactive topics
# Enable the deletion of inactive topics. This parameter need to cooperate with the allowAutoTopicCreation parameter.
# If brokerDeleteInactiveTopicsEnabled is set to true, we should ensure that allowAutoTopicCreation is also set to true.
brokerDeleteInactiveTopicsEnabled=true

# How often to check for inactive topics
Expand Down
3 changes: 2 additions & 1 deletion deployment/terraform-ansible/templates/broker.conf
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,8 @@ allowAutoSubscriptionCreation=true
# The number of partitioned topics that is allowed to be automatically created if allowAutoTopicCreationType is partitioned.
defaultNumPartitions=1

# Enable the deletion of inactive topics
# Enable the deletion of inactive topics. This parameter need to cooperate with the allowAutoTopicCreation parameter.
# If brokerDeleteInactiveTopicsEnabled is set to true, we should ensure that allowAutoTopicCreation is also set to true.
brokerDeleteInactiveTopicsEnabled=true

# How often to check for inactive topics
Expand Down

0 comments on commit 09e5a86

Please sign in to comment.