Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][doc] Cleanup Subscription in functions are not propely expl… #867

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

AlvaroStream
Copy link
Contributor

Fixes apache/pulsar#22333

Add the command argument and the default value that is true

✅ Contribution Checklist

…ained.

Fixes apache/pulsar#22333

Add the command argument and the default value
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Please cover 3.2.x docs too

@lhotari
Copy link
Member

lhotari commented Mar 25, 2024

I covered the 3.2.x docs. @AlvaroStream It seems that your base version was old and didn't contain the 3.2.x directory.

@lhotari lhotari merged commit 9bbad55 into apache:main Mar 25, 2024
2 checks passed
@AlvaroStream
Copy link
Contributor Author

Sorry, I though I covered all the documents.

Thanks for the commit improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] Cleanup Subscription in functions is not properly documented
2 participants