-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add containerized building #576
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Still, we need |
Confirm, it works. |
Maybe it has sense to implement full build process with Docker? Let's say, I have such a problem in Python script that runs ![]() https://github.com/apache/pulsar-site/actions/runs/4979344185/jobs/8911494860 I'm not sure how I can debug it locally. The current Docker setup doesn't have any mention of Python, poetry package manager, etc. |
@visortelle I think of it just now. Let me try it out. |
@visortelle For the specific issue, maybe try out There are too much legacy scripts logic that need some time to migrate.. |
@tisonkun I tried locally. No changes in |
@tisonkun by the way, I used another command to run child process, and now I at least see the concrete error message import subprocess
...
def run_command(command):
process = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True)
stdout, stderr = process.communicate()
if stdout:
print("STDOUT:")
print(stdout.decode('utf-8'))
if stderr:
print("STDERR:")
print(stderr.decode('utf-8'))
...
run_command('yarn install') ![]() https://github.com/tealtools/pulsar-site-pip-249/actions/runs/4980539690/jobs/8913580517 Maybe the |
Let's discuss in your fork. It's unrelated to this PR or the upstream code. Basically, you need to run |
I'll merge this patch first. Further improvement can be done later. I'll try to directly push some fix on the PIP-249 branch. |
Works great! |
This PR fixes apache/pulsar#20272
doc
doc-required
doc-not-needed
doc-complete
cc @visortelle @asafm welcome to test in your env:
... should simply work and you can browse at http://localhost:3000/