Remove JWT validation from production code #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
lhotari
approved these changes
Feb 7, 2024
eolivelli
approved these changes
Feb 7, 2024
JLLeitschuh
deleted the
improve/JLL/remove-JWT-validation-from-production-code
branch
liangyepianzhou
pushed a commit
that referenced
this pull request
Jan 12, 2025
Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com> (cherry picked from commit 4476f5e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CodeQL was flagging the current use of JWT as being vulnerable as
validateBrokerTokenwasn't actuallyperforming validlidation of the signature.
Since the logic is unused, except for in test, the entire chunk of logic has been moved exclusively to tests.
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Move
JwtServiceImpl#validateBrokerTokenlogic intoBrokerTokensServiceImplTestVerifying this change
./gradlew buildchecks.