Conversation
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Thanks for preparing the release process @michaeljmarshall!
Comments inline.
|
|
||
| ## Build Release Notes | ||
|
|
||
| Before creating the RC, you need to build and commit the release notes for the release. |
There was a problem hiding this comment.
How to build and where to commit?
There was a problem hiding this comment.
I haven't really defined this yet. The helm chart doesn't move that quickly, so at this point, I was thinking it would be manual. Apache Airflow has a script to generate this information: https://github.com/apache/airflow/blob/main/dev/chart/build_changelog_annotations.py.
| The Release Candidate artifacts we vote upon should be the exact ones we vote against, | ||
| without any modification than renaming – i.e. the contents of the files must be | ||
| the same between voted release candidate and final release. | ||
| Because of this the version in the built artifacts that will become the | ||
| official Apache releases must not include the rcN suffix. |
There was a problem hiding this comment.
I suggest we don't do manual line wrap. But this is not a hard requirement :)
There was a problem hiding this comment.
I only had manual line wraps because I copied the Airflow process and wanted to provide reviewers a meaningful diff. I don't feel strongly either way.
|
|
||
| # Move the artifacts to svn folder & commit (don't copy or copy & remove - index.yaml) | ||
| for f in ../../../pulsar-dist-dev/helm-chart/$RC/*; do svn cp $f ${$(basename $f)/}; done | ||
| svn rm index.yaml |
There was a problem hiding this comment.
In this release manual, it doesn't talk about updating the index.yaml file on https://pulsar.apache.org/charts/index.yaml, and here we remove the index.yaml file on dist.a.o
Then where do we host the index.yaml file?
I suggest we host it on the dist.a.o and redirect https://pulsar.apache.org/charts/index.yaml to there.
There was a problem hiding this comment.
Great point, I will take a look at how we update the index.yaml tomorrow. I support with hosting it on dist.a.o.
There was a problem hiding this comment.
The official helm/chart-releaser may help.
Basically, we port the automation proposed in #292 with manual steps.
There was a problem hiding this comment.
Makes sense. I am going to merge some final PRs today and then start testing out the workflow to see how it would work. It will likely require some tweaking.
There was a problem hiding this comment.
Could you summarize a bit what actions we perform against the index.yaml file?
I can see that we remove here and add in the steps below, but it's not quite straightforward to review - a flow about where and what we do with the index.yaml file helps.
There was a problem hiding this comment.
That is fair criticism. I'll document the flow when I get to that step next week.
Co-authored-by: tison <wander4096@gmail.com>
|
Thanks for your thorough review @tisonkun. I will work on improving the doc tomorrow (my time). |
|
I am going to merge this new process now, and we'll tweak it as needed. |
|
|
||
| # Move the artifacts to svn folder & commit (don't copy or copy & remove - index.yaml) | ||
| for f in ../../../pulsar-dist-dev/helm-chart/$RC/*; do svn cp $f ${$(basename $f)/}; done | ||
| svn rm index.yaml |
There was a problem hiding this comment.
Could you summarize a bit what actions we perform against the index.yaml file?
I can see that we remove here and add in the steps below, but it's not quite straightforward to review - a flow about where and what we do with the index.yaml file helps.
3 participants
Relates to #290
Motivation
Make the Apache Pulsar Helm Chart release follow ASF rules for voting, and make the helm binary available via dist.apache.org. By following the information in https://issues.apache.org/jira/browse/LEGAL-573 and in the Apache Airflow project https://github.com/apache/airflow/blob/main/dev/README_RELEASE_HELM_CHART.md, I built this new release process. It will likely need some iterative improvement.
Modifications
Verifying this change