Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change license header for gh action.yml #105

Closed
wants to merge 1 commit into from

Conversation

cbornet
Copy link
Contributor

@cbornet cbornet commented Dec 8, 2022

No description provided.

@cbornet cbornet requested a review from lhotari December 8, 2022 09:43
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the ASF specific license header instead.

You can take a look at apache/pulsar-site#315 and https://github.com/apache/skywalking-eyes for automatically check and fix this stuff.

@lhotari
Copy link
Member

lhotari commented Dec 8, 2022

replaced by #107

@lhotari lhotari closed this Dec 8, 2022
@lhotari
Copy link
Member

lhotari commented Dec 8, 2022

We should use the ASF specific license header instead.

You can take a look at apache/pulsar-site#315 and https://github.com/apache/skywalking-eyes for automatically check and fix this stuff.

Thanks @tisonkun .

The gradle build in pulsar-client-reactive is already using licenser plugin. I configured it properly and added a check for CI. #107 contains the changes.

@cbornet cbornet deleted the action-license branch December 8, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants