[feat] Support consumer batch receive.#33
Merged
BewareMyPower merged 2 commits intoapache:mainfrom Nov 16, 2022
Merged
Conversation
BewareMyPower
requested changes
Nov 10, 2022
Contributor
BewareMyPower
left a comment
There was a problem hiding this comment.
Could you wrap the BatchReceivePolicy class into the pulsar module? It's better to avoid using the class from _pulsar module directly.
Member
Author
Yes, When I coded, I struggled with whether to implement a wrapper. It turns out that implementing a wrapper class can clearly define the input parameters and docs. I changed it, PTAL. |
Member
|
@shibd you may try to rebase on the latest master so that we're sure there's no doc string syntax regression :) |
RobertIndie
approved these changes
Nov 15, 2022
BewareMyPower
approved these changes
Nov 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#39
Modifications