Support building with the default apt sources on Ubuntu 20.04#21
Closed
BewareMyPower wants to merge 2 commits intoapache:mainfrom
Closed
Support building with the default apt sources on Ubuntu 20.04#21BewareMyPower wants to merge 2 commits intoapache:mainfrom
BewareMyPower wants to merge 2 commits intoapache:mainfrom
Conversation
### Motivation Currently the Python client cannot be built with the default apt sources on Ubuntu 20.04, whose default CMake version is 3.16. However, even after I installed CMake 3.24 on Ubuntu 20.04, CMake would still fail to find Boost.Python. ### Modifications To fix the Boost.Python not found issue, find the `Python` component instead of `Python3` when finding Boost. In addition, when finding Python3, find the `Development` component instead of the `Development.Module`, which is a sub-component of `Development`. See https://cmake.org/cmake/help/latest/module/FindPython3.html. After that, the minimum required CMake version becomes back to 3.12 from 3.18, which was upgraded in apache#11.
Contributor
Author
|
The CMake error is: or the following messages with |
Contributor
Author
|
It can be fixed by a simple CMake upgrade now after #23. We cannot use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the Python client cannot be built with the default apt sources on Ubuntu 20.04, whose default CMake version is 3.16. However, even after I installed CMake 3.24 on Ubuntu 20.04, CMake would still fail to find Boost.Python.
Modifications
To fix the Boost.Python not found issue, find the
Pythoncomponent instead ofPython3when finding Boost.In addition, when finding Python3, find the
Developmentcomponent instead of theDevelopment.Module, which is a sub-component ofDevelopment. Seehttps://cmake.org/cmake/help/latest/module/FindPython3.html.
After that, the minimum required CMake version becomes back to 3.12 from 3.18, which was upgraded in
#11.