Merged
Conversation
merlimat
reviewed
Apr 19, 2023
| extras_require["avro"] = sorted( | ||
| { | ||
| "fastavro==0.24.0" | ||
| "fastavro==1.7.3" |
Contributor
There was a problem hiding this comment.
Could we just remove the version here and let pip resolve the latest?
Member
There was a problem hiding this comment.
Fixed version or at least a ^x.y.z manner can prevent unintentional version bump?
Contributor
Author
There was a problem hiding this comment.
If we let pip resolve the latest, maybe the support for some older Python versions might be dropped unexpectedly.
I think we should add extra workflows to verify the compatibility for the lowest version and highest version that we supported.
merlimat
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67
This PR fixes the client cannot be installed with
[avro]. Take Python 3.11 on Windows as example:TODO: fix the client cannot be installed with
[all].