Skip to content

[feat][npm publish]exclude unnecessary files to be included in npm package #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davidkhala
Copy link

exclude unnecessary files to be included in npm package

A small PR without linked to any issue

Motivation

After I investigate the node_modules I get via npm install, I see some source files leakage as redundency to end user

Modifications

Via this change, the folder tests/ and .github will be exluded in next npm publish release

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • doc-not-needed

exclude unnecessary files to be included in npm package
@shibd shibd added this to the 1.14.0 milestone Jun 11, 2025
@shibd
Copy link
Member

shibd commented Jun 11, 2025

Hi, @davidkhala should add license to .npmignore, or ignore it.

Using ignore file
✗ License not found in .npmignore
License check failed. 1 file(s) did not have the license.
Command failed

@davidkhala
Copy link
Author

@shibd does it look good now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants