Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade semver #338

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Upgrade semver #338

merged 3 commits into from
Jul 21, 2023

Conversation

massakam
Copy link
Contributor

@massakam massakam commented Jul 20, 2023

Motivation

There seems to be a security vulnerability in the semver module that @mapbox/node-pre-gyp depends on, so I will upgrade these.
https://nvd.nist.gov/vuln/detail/CVE-2022-25883

Modifications

  • Upgrade @mapbox/node-pre-gyp to 1.0.11
  • Upgraded semver to versions with vulnerability fixes

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc-not-needed

@massakam massakam added this to the 1.10.0 milestone Jul 20, 2023
@massakam massakam self-assigned this Jul 20, 2023
@massakam
Copy link
Contributor Author

Removed file extensions from all require statements because ESLint started throwing errors.

$ npm run lint

> pulsar-client@1.10.0-rc.0 lint
> clang-format-lint src/*.cc src/*.h && eslint --ext .js .


/home/massakam/github/pulsar-client-node/GenCertFile.js
  20:24  error  Unexpected use of file extension "js" for "./src/Client.js"  import/extensions

/home/massakam/github/pulsar-client-node/index.js
  21:35  error  Unexpected use of file extension "js" for "./src/AuthenticationTls.js"     import/extensions
  22:38  error  Unexpected use of file extension "js" for "./src/AuthenticationAthenz.js"  import/extensions
  23:37  error  Unexpected use of file extension "js" for "./src/AuthenticationToken.js"   import/extensions
  24:38  error  Unexpected use of file extension "js" for "./src/AuthenticationOauth2.js"  import/extensions
  25:24  error  Unexpected use of file extension "js" for "./src/Client.js"                import/extensions

/home/massakam/github/pulsar-client-node/pkg/load_test.js
  20:24  error  Unexpected use of file extension "js" for "../index.js"  import/extensions

/home/massakam/github/pulsar-client-node/tests/client.test.js
  20:29  error  Unexpected use of file extension "js" for "./http_utils.js"  import/extensions
  21:24  error  Unexpected use of file extension "js" for "../index.js"      import/extensions

/home/massakam/github/pulsar-client-node/tests/consumer.test.js
  20:24  error  Unexpected use of file extension "js" for "../index.js"  import/extensions

/home/massakam/github/pulsar-client-node/tests/end_to_end.test.js
   21:24  error    Unexpected use of file extension "js" for "../index.js"  import/extensions
  312:14  warning  Unexpected constant condition                            no-constant-condition
  357:26  warning  'message' is defined but never used                      no-unused-vars
  357:35  warning  'reader' is defined but never used                       no-unused-vars
  389:5   warning  Test has no assertions                                   jest/expect-expect
  425:20  warning  'message' is defined but never used                      no-unused-vars
  425:29  warning  'messageConsumer' is defined but never used              no-unused-vars
  435:26  warning  'message' is defined but never used                      no-unused-vars
  435:35  warning  'messageConsumer' is defined but never used              no-unused-vars

/home/massakam/github/pulsar-client-node/tests/producer.test.js
  20:24  error  Unexpected use of file extension "js" for "../index.js"  import/extensions

/home/massakam/github/pulsar-client-node/tests/reader.test.js
  21:24  error  Unexpected use of file extension "js" for "../index.js"  import/extensions

✖ 21 problems (13 errors, 8 warnings)

@shibd shibd merged commit 301252b into apache:master Jul 21, 2023
@massakam massakam deleted the upgrade-semver branch July 21, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants