[fix] Add tests for produce and consume with TLS enabled #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertIndie
reviewed
Apr 6, 2023
shibd
approved these changes
Apr 6, 2023
RobertIndie
approved these changes
Apr 6, 2023
shibd
requested changes
Apr 6, 2023
shibd
pushed a commit
to streamnative/pulsar-client-node
that referenced
this pull request
Apr 9, 2023
* Add tests for produce and consume with TLS enabled * Add error message output (cherry picked from commit 74461ca)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There was a problem with the code just a little while ago where specifying an HTTPS URL as the
serviceUrlcaused a segfault. This has been fixed by #310, but since there were no tests for this issue yet, I added it.In addition, it seemed that the place where
-fvisibility=hiddenshould be added was wrong, so I fixed it.Verifying this change
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)