Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ansi-regex #293

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Upgrade ansi-regex #293

merged 1 commit into from
Feb 7, 2023

Conversation

hrsakai
Copy link
Contributor

@hrsakai hrsakai commented Feb 7, 2023

Motivation

ansi-regex-2.1.1 is now required by node-pre-gyp dependency, but that version has security vulnerabilities.
https://security.snyk.io/vuln/SNYK-JS-ANSIREGEX-1583908

@mapbox/node-pre-gyp@1.0.9 > npmlog@5.0.1 > gauge@3.0.2 > 
wide-align@1.1.3 > string-width@1.0.2 > strip-ansi@3.0.1 > ansi-regex@2.1.1

Modifications

Upgrade ansi-regex by running npm update wide-align string-width.

@mapbox/node-pre-gyp@1.0.9 > npmlog@5.0.1 > gauge@3.0.2 > 
wide-align@1.1.5 > string-width@4.2.3 > strip-ansi@6.0.1 > ansi-regex@5.0.1 

ansi-regex-2.1.1 is required only in devDependencies after merging this pr.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@hrsakai hrsakai added this to the 1.9.0 milestone Feb 7, 2023
@hrsakai hrsakai self-assigned this Feb 7, 2023
Copy link
Contributor

@massakam massakam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@massakam massakam merged commit 653394a into apache:master Feb 7, 2023
@hrsakai hrsakai deleted the upgrade-wide-align branch February 7, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants