Upgrade the version of OpenSSL that compiles MacOS cpp client dependencies. #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
shibd
changed the title
RobertIndie
approved these changes
Dec 1, 2022
merlimat
approved these changes
Dec 5, 2022
shibd
added a commit
to shibd/pulsar-client-node
that referenced
this pull request
Jan 7, 2023
This reverts commit cdd4f58.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
About compiling MacOS CPP client dependencies. OpensSSL 1.1.1q has a compilation bug, We need to solve this by adding this line manually:
pulsar-client-node/pkg/mac/build-cpp-deps-lib.sh
Line 62 in 10ef71a
In 1.1.1s version, this bug has been fixed.
Modifications
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)