Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix wrong check eventime by default #843

Merged
merged 4 commits into from
Sep 14, 2022

Conversation

liangyuanpeng
Copy link
Contributor

Motivation

time.Time should use IsZero() to check for initialization and now, it use compare to 0, it on the wrong side.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@liangyuanpeng liangyuanpeng changed the title Fix wrong check eventime by default [Do Not Merge] Fix wrong check eventime by default Sep 13, 2022
@liangyuanpeng liangyuanpeng changed the title [Do Not Merge] Fix wrong check eventime by default Fix wrong check eventime by default Sep 13, 2022
@liangyuanpeng liangyuanpeng changed the title Fix wrong check eventime by default [bugfix] Fix wrong check eventime by default Sep 13, 2022
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@merlimat merlimat merged commit b06e198 into apache:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants