Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NackBackoffPolicy.Next return time.Duration #825

Merged
merged 0 commits into from
Aug 23, 2022
Merged

NackBackoffPolicy.Next return time.Duration #825

merged 0 commits into from
Aug 23, 2022

Conversation

h-hy
Copy link
Contributor

@h-hy h-hy commented Aug 10, 2022

image

NackBackoffPolicy.Next return int64 type before, but it used as time.Durtion.
image

@wolfstudy wolfstudy self-requested a review August 23, 2022 06:16
@wolfstudy wolfstudy modified the milestones: v0.10.0, v0.9.0 Aug 23, 2022
wolfstudy
wolfstudy approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@h-hy h-hy merged commit a09460e into apache:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfstudy wolfstudy wolfstudy approved these changes

Assignees

@h-hy h-hy

Labels
type/bug
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@h-hy @wolfstudy