[Issue 763][producer] Fix deadlock in Producer Send when message fails to encode. #762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for producer schema encode.
Fixes #763
Motivation
When using Producer, if the ProducerMessage.Value fails to encode using the producer's Schema, the code never returns when using
producer.Send()
and never executes the callback when usingproducer.SendAsync()
. Additionally, the publishSemaphore that was Acquired is never released.Modifications
When an error is returned by Schema Encode, release the Semaphore and execute the callback.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation