Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] producer runEventsLoop for reconnect early exit #721

Merged
merged 10 commits into from
Feb 9, 2022
Merged

[Bugfix] producer runEventsLoop for reconnect early exit #721

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e616355
Fix closed connection leak
billowqiu Jan 21, 2022
b949459
Fix closed connection leak
billowqiu Jan 21, 2022
9e82fef
Merge branch 'master' of github.com:billowqiu/pulsar-client-go
billowqiu Jan 21, 2022
566623b
bugfix: runEventsLoop for reconnect early exit
billowqiu Feb 5, 2022
6a1b11b
[optimize] add log when reconnect
billowqiu Feb 5, 2022
936c819
Merge branch 'master' into master
billowqiu Feb 5, 2022
bb283a5
[Bugfix]fix panic
billowqiu Feb 5, 2022
1b62d2f
Merge branch 'master' of github.com:billowqiu/pulsar-client-go
billowqiu Feb 5, 2022
15d2b07
[Bugfix]remove log conn ID
billowqiu Feb 5, 2022
cca8635
[optimize]Distinguish failed create producer log
billowqiu Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix closed connection leak
  • Loading branch information
@billowqiu
billowqiu committed Jan 21, 2022
commit e6163552c75bb34aacfffde062972a1e021c8e6b
1 change: 1 addition & 0 deletions pulsar/internal/connection_pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ func (p *connectionPool) GetConnection(logicalAddr *url.URL, physicalAddr *url.U
// remove stale/failed connection
if conn.closed() {
delete(p.connections, key)
conn.Close()
p.log.Infof("Removed connection from pool key=%s logical_addr=%+v physical_addr=%+v",
key, conn.logicalAddr, conn.physicalAddr)
conn = nil // set to nil so we create a new one
Expand Down