Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nack backoff policy for SDK #660

Merged
merged 12 commits into from
Nov 8, 2021
Merged

Support nack backoff policy for SDK #660

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7efb2be
Support nack backoff policy for SDK
wolfstudy Nov 3, 2021
d471316
add test case and fix some logic
wolfstudy Nov 4, 2021
16c0912
fix action ciu
wolfstudy Nov 4, 2021
4fa4e50
fix action ci
wolfstudy Nov 4, 2021
343a28b
fix some logic
wolfstudy Nov 4, 2021
c970183
fix data race
wolfstudy Nov 4, 2021
9ca14c6
fix data race
wolfstudy Nov 4, 2021
89dcd77
fix a little
wolfstudy Nov 4, 2021
6bf2991
fix data race
wolfstudy Nov 4, 2021
014fe8d
fix data race
wolfstudy Nov 4, 2021
2fc332f
fix some comments
wolfstudy Nov 5, 2021
b77b314
fix test case
wolfstudy Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix action ciu 
Signed-off-by: xiaolongran <xiaolongran@tencent.com>
  • Loading branch information
@wolfstudy
wolfstudy committed Nov 4, 2021
commit 16c0912149feb356df4a4b96e9f5d2c4e18e3ad0
2 changes: 1 addition & 1 deletion pulsar/consumer_impl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func newConsumer(client *client, options ConsumerOptions) (Consumer, error) {
}
}

if options.NackBackoffPolicy == nil && options.EnableDefaultNackBackoffPolicy == true {
if options.NackBackoffPolicy == nil && options.EnableDefaultNackBackoffPolicy {
options.NackBackoffPolicy = new(defaultNackBackoffPolicy)
}

Expand Down
1 change: 1 addition & 0 deletions pulsar/negative_backoff_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ type NackBackoffPolicy interface {
Next(redeliveryCount uint32) int64
}

// defaultNackBackoffPolicy is default impl for NackBackoffPolicy.
type defaultNackBackoffPolicy struct {}

func (nbp *defaultNackBackoffPolicy) Next(redeliveryCount uint32) int64 {
Expand Down