Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #401] Add orderingKey apis #427

Merged
merged 4 commits into from
Dec 23, 2020

Conversation

freeznet
Copy link
Contributor

Fixes #401

Motivation

According to apache/pulsar#4079, orderingKey was introduced to let user set message order manually, currently pulsar-client-go do not have related apis exposed to user. We should add orderingKey related apis to pulsar-client-go.

Modifications

  • add OrderingKey to ProducerMessage
  • add OrderingKey() to Message interface
  • sync OrderingKey to SingleMessageMetadata
  • tests

@freeznet freeznet changed the title [Issue #401] Add ordering key apis [Issue #401] Add orderingKey apis Dec 22, 2020
@freeznet
Copy link
Contributor Author

@wolfstudy would you please help to review this pr, thanks.

Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wolfstudy wolfstudy added this to the 0.4.0 milestone Dec 23, 2020
@wolfstudy wolfstudy merged commit 9b20cc0 into apache:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add OrderingKey related apis
2 participants