Fixed pooled buffer lifecycle #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
force-pushed
the
fix-buffer-pooling
branch
from
4bb8a2b to
752d7bf
Compare
ivankelly
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The buffer pooling introduced in #292 has a serious bug in that the buffer gets released back to the pool after it's written on the connection. The problem is that, if there's a failure, a message can be written again after the reconnection, in which case we're sending garbage data.
We need to tie the buffer lifecycle of the send request instead and, in that optic, it doesn't make to have the pool on the connection, rather it should be at the partition producer level.