Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve] getMessagesById gets all messages #1194

Merged
merged 2 commits into from
Mar 8, 2024
Merged

[Improve] getMessagesById gets all messages #1194

merged 2 commits into from
Mar 8, 2024

Conversation

crossoverJie
Copy link
Member

Motivation

To keep consistent with the Java client.

Releted PR: apache/pulsar#21918

Modifications

Add getMessagesById interface.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (yes)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (GoDocs)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

RobertIndie
RobertIndie approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pulsaradmin/pkg/admin/subscription_test.go Outdated Show resolved Hide resolved
@crossoverJie @RobertIndie
Update pulsaradmin/pkg/admin/subscription_test.go
0c472e7 
Co-authored-by: Zike Yang <zike@apache.org>
@RobertIndie RobertIndie merged commit 143fa23 into apache:master Mar 8, 2024
8 checks passed
@RobertIndie RobertIndie added this to the v0.13.0 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertIndie RobertIndie RobertIndie approved these changes

Assignees

@crossoverJie crossoverJie

Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@crossoverJie @RobertIndie