Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VERSION and stable.txt files #1158

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

RobertIndie
Copy link
Member

@RobertIndie RobertIndie commented Jan 22, 2024

Motivation

We currently have two hardcoded version files in place: VERSION which represents the current version and stable.txt which represents the current stable version. However, I'm curious about the intended function of these files. Are they merely for developers to conveniently reference the current and stable versions? And what is our approach to managing these files? For instance, how do we determine what constitutes a stable version? If there's no compelling reason to keep these files, I'd propose to remove them.

Please see more discussion here: https://lists.apache.org/thread/mrntb1y7ws173ohtdvz1v8q86pg50cn2

Modifications

  • Remove VERSION and stable.txt files.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@RobertIndie RobertIndie added this to the v0.12.0 milestone Jan 22, 2024
@RobertIndie RobertIndie self-assigned this Jan 22, 2024
@BewareMyPower
Copy link
Contributor

Could you resolve the conflicts?

@BewareMyPower BewareMyPower merged commit 6d9cbd8 into apache:master Mar 6, 2024
8 checks passed
@RobertIndie RobertIndie deleted the remove-version-files branch March 7, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants