Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] update Unsubscribe() interface comment #1146

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

geniusjoe
Copy link
Contributor

@geniusjoe geniusjoe commented Dec 20, 2023

Motivation

I recently notice that some users using Unsubscribe() interface to stop receiving messages from current subscribed topic. But this action can lead to losing messages if retention policy exceed.

Modifications

We can add some comment in the Unsubscribe interface, and this comment can base on native Java sdk client.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? N/A
  • If a feature is not applicable for documentation, explain why? no
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation. N/A

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun merged commit 3a1a766 into apache:master Jan 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants