-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][txn]Implement transactional consumer/producer API #1002
Conversation
Is this the last PR about transactions? It's better to add some sample code to examples. |
Yes, this is the last PR concerning transactions. In the tests I've added, I've only used the API to perform the tests, which can serve as an initial example. Adding more detailed examples to the documentation might be more appropriate? |
Yes, the documentation can be described step by step, and complete examples are placed in the examples folder. We can push in a later PR. |
Hi @liangyepianzhou thanks for introducing this great feature! ======================================== As we discussed just now, for the doc side: ✅ Pulsar feature matrixI've ticked the three boxes (client, producer, consumer) of "Transactions" for Go. ✅ Pulsar client docs
BTW, ======================================== Feel free to reach out to me if you have questions. TIA! |
Could you please retake a look? @BewareMyPower @shibd |
Sorry, I'll take a look at it today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, left some small comments.
## Motivation The go client has already supported the transaction. apache/pulsar-client-go#1002 But the client feature matrix doesn't reflect this. This PR marks the transaction support for go client feature matrix
Master Issue:#932
Motivation
Implement transaction coordinator client.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation