Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support key based batcher for key_shared #172

Closed
wolfstudy opened this issue Jan 14, 2020 · 1 comment · Fixed by #400
Closed

Support key based batcher for key_shared #172

wolfstudy opened this issue Jan 14, 2020 · 1 comment · Fixed by #400
Assignees
@freeznet
Labels
help wanted anyone who are interested in could help on it triage/week-3 type/feature

Comments

@wolfstudy
Copy link
Member

wolfstudy commented Jan 14, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.

If users want to enable batch in key_shared subscription type, we need to support key based batcher feature.

Describe the solution you'd like

Support key based batcher in go client, reference to: apache/pulsar#4435
@wolfstudy wolfstudy added help wanted anyone who are interested in could help on it type/feature labels Jan 14, 2020
@sijie sijie mentioned this issue Jan 15, 2020
Closed
@freeznet
Copy link
Contributor

I can try to implement this feature 🔢

@freeznet freeznet mentioned this issue Nov 25, 2020
Merged
wolfstudy pushed a commit that referenced this issue Dec 1, 2020
@freeznet
[Issue 172] Add key based batcher (#400)
154bff0 
Fixes #172

### Motivation

Add a new batch message container named `keyBasedBatchContainer` to support batching message in key_shared subscription mode.

### Modifications

- add `BatchBuilder` interface, add `FlushBatches` and `IsMultiBatches` func
- change old `BatchBuilder` struct to `batchContainer`
- add `keyBasedBatchContainer`
- add tests

### Verifying this change

This change added tests and can be verified as follows:

  - *Added integration tests for key based batch producer with multiple consumer in KeyShared mode*
  - *Added integration tests for message ordering with key based batch producer and KeyShared consumer*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@freeznet freeznet

Labels
help wanted anyone who are interested in could help on it triage/week-3 type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Issue 172] Add key based batcher freeznet/pulsar-client-go
3 participants
@sijie @freeznet @wolfstudy