[flaky-test] Fix very flaky tests for TEST_P#59
Merged
merlimat merged 1 commit intoapache:mainfrom Oct 21, 2022
Merged
Conversation
Fixes apache#58 #24 ### Motivation gtest-parallel runs tests in different processes, not threads. So the topic name could be the same even if it has the timestamp suffix. Then `ConsumerBusy` error would occur. ### Modifications In each `TEST_P` method, convert `GetParam()` to a unique string to avoid topic conflict.
RobertIndie
approved these changes
Oct 21, 2022
merlimat
approved these changes
Oct 21, 2022
merlimat
pushed a commit
that referenced
this pull request
Oct 21, 2022
Fixes #58 #24 ### Motivation gtest-parallel runs tests in different processes, not threads. So the topic name could be the same even if it has the timestamp suffix. Then `ConsumerBusy` error would occur. ### Modifications In each `TEST_P` method, convert `GetParam()` to a unique string to avoid topic conflict.
This was referenced Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58 #24
Motivation
gtest-parallel runs tests in different processes, not threads. So the topic name could be the same even if it has the timestamp suffix. Then
ConsumerBusyerror would occur.Modifications
In each
TEST_Pmethod, convertGetParam()to a unique string to avoid topic conflict.Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)