Merged
Conversation
3e3a029 to
f955328
Compare
merlimat
reviewed
Oct 12, 2022
README.md
Outdated
| brew install openssl | ||
|
|
||
| # For x86_64 macOS | ||
| export OPENSSL_INCLUDE_DIR=/usr/local/opt/openssl/include/ |
Contributor
There was a problem hiding this comment.
These variables are not needed anymore.
merlimat
approved these changes
Oct 12, 2022
merlimat
added a commit
that referenced
this pull request
Oct 12, 2022
* Fix Ubuntu and macOS build guide * Fixed readme Co-authored-by: Matteo Merli <mmerli@apache.org>
|
Hi @merlimat I am using M1 Mac and encountering error Commands Log |
Contributor
|
@Seitk You should specify the cmake -DCMAKE_PREFIX_PATH=/opt/homebrew/Cellar/protobuf@3/3.20.3 /* other options... */Besides, when you enable the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, some build guide is out-of-date. We need to update the build guide.
The first issue is when we install the dependencies for Ubuntu, we still need manually compile and install google test and google mock.
However, we can use
libgmock-devto replace thegoogle-mock, since thelibgmock-devalready contains the static-link library.Same as the
libgtest-dev.The second issue is macOS dependency. The
boost-pythonhas already been removed from the brew core. We should always useboost-python3.The third one is
OPENSSL_INCLUDE_DIRandOPENSSL_ROOT_DIR.For m1 macOS, the brew preferred prefix is
/opt/homebrew/opt, Intel macOS is/usr/local.So we set the
OPENSSL_INCLUDE_DIR, OPENSSL_ROOT_DIR. We should consider the different platforms.Modifications
Fix Ubuntu and macOS build guide
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)