Fix multi-topics consumer could receive old messages after seek #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation See apache/pulsar#21945 ### Modifications In C++ client, the multi-topics consumer receives messages by configuring internal consumers with a message listener that adds messages to `incomingMessages_`. So this patch pauses the listeners before seek and resumes them after seek. Add `MultiTopicsConsumerTest.testSeekToNewerPosition` for test.
BewareMyPower
force-pushed
the
bewaremypower/multi-consumer-seek
branch
from
73e3089 to
d65f123
Compare
BewareMyPower
changed the title
|
@merlimat @shibd @RobertIndie Could any of you take a look? |
RobertIndie
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See apache/pulsar#21945
Modifications
In C++ client, the multi-topics consumer receives messages by
configuring internal consumers with a message listener that adds
messages to
incomingMessages_. So this patch pauses the listenersbefore seek and resumes them after seek.
Add
MultiTopicsConsumerTest.testSeekToNewerPositionfor test.