Skip to content

Enable required check status for PR validation#33

Merged
merlimat merged 2 commits intoapache:mainfrom
RobertIndie:required-ci
Oct 10, 2022
Merged

Enable required check status for PR validation#33
merlimat merged 2 commits intoapache:mainfrom
RobertIndie:required-ci

Conversation

@RobertIndie
Copy link
Member

Motivation

Currently, there is no required workflow for the PR.

Modifications

Enable required check status for pr validation

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@RobertIndie RobertIndie self-assigned this Oct 10, 2022
@merlimat merlimat added the build label Oct 10, 2022
@merlimat merlimat added this to the 3.0.0 milestone Oct 10, 2022
@merlimat merlimat merged commit 5f2b786 into apache:main Oct 10, 2022
@BewareMyPower
Copy link
Contributor

Could you take a look at the Build Alpine Linux APK Package task? It stuck at Waiting for status to be reported

image

@BewareMyPower
Copy link
Contributor

image

In addition, these two tasks (especially the most important unit tests task) are not required.

@RobertIndie
Copy link
Member Author

RobertIndie commented Oct 11, 2022

image

In addition, these two tasks (especially the most important unit tests task) are not required.

Where is this PR? I found that there is no CentOS7 matrix in the CI job:

- name: 'Windows x64'
os: windows-2022
triplet: x64-windows
vcpkg_dir: 'C:\vcpkg'
suffix: 'windows-win64'
generator: 'Visual Studio 17 2022'
arch: '-A x64'
- name: 'Windows x86'
os: windows-2022
triplet: x86-windows
vcpkg_dir: 'C:\vcpkg'
suffix: 'windows-win32'
generator: 'Visual Studio 17 2022'
arch: '-A Win32'

Did you add the new matrix in your PR?

The unit test is dependent by other jobs.
image

But I'm OK to add it as a required job.

@BewareMyPower
Copy link
Contributor

I found that there is no CentOS7 matrix in the CI job:

Because it was removed in #25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants