Enable required check status for PR validation#33
Merged
merlimat merged 2 commits intoapache:mainfrom Oct 10, 2022
Merged
Conversation
merlimat
approved these changes
Oct 10, 2022
Contributor
Contributor
Member
Author
Where is this PR? I found that there is no pulsar-client-cpp/.github/workflows/ci-pr-validation.yaml Lines 88 to 101 in b6653d6 Did you add the new matrix in your PR? The unit test is dependent by other jobs. But I'm OK to add it as a required job. |
Contributor
Because it was removed in #25. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation
Currently, there is no required workflow for the PR.
Modifications
Enable required check status for pr validation
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)