Skip to content

[feat] Expose start message id inclusive configuration to C API #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merlimat merged 1 commit into from
Oct 9, 2022
Merged

[feat] Expose start message id inclusive configuration to C API #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions include/pulsar/c/consumer_configuration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,12 @@ PULSAR_PUBLIC void pulsar_consumer_configuration_set_auto_ack_oldest_chunked_mes
PULSAR_PUBLIC int pulsar_consumer_configuration_is_auto_ack_oldest_chunked_message_on_queue_full(
pulsar_consumer_configuration_t *consumer_configuration);

PULSAR_PUBLIC void pulsar_consumer_configuration_set_start_message_id_inclusive(
pulsar_consumer_configuration_t *consumer_configuration, int start_message_id_inclusive);

PULSAR_PUBLIC int pulsar_consumer_configuration_is_start_message_id_inclusive(
pulsar_consumer_configuration_t *consumer_configuration);

// const CryptoKeyReaderPtr getCryptoKeyReader()
//
// const;
Expand Down
10 changes: 10 additions & 0 deletions lib/c/c_ConsumerConfiguration.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,3 +217,13 @@ int pulsar_consumer_configuration_is_auto_ack_oldest_chunked_message_on_queue_fu
pulsar_consumer_configuration_t *consumer_configuration) {
return consumer_configuration->consumerConfiguration.isAutoAckOldestChunkedMessageOnQueueFull();
}

void pulsar_consumer_configuration_set_start_message_id_inclusive(
pulsar_consumer_configuration_t *consumer_configuration, int start_message_id_inclusive) {
consumer_configuration->consumerConfiguration.setStartMessageIdInclusive(start_message_id_inclusive);
}

int pulsar_consumer_configuration_is_start_message_id_inclusive(
pulsar_consumer_configuration_t *consumer_configuration) {
return consumer_configuration->consumerConfiguration.isStartMessageIdInclusive();
}
3 changes: 3 additions & 0 deletions tests/c/c_ConsumerConfigurationTest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,7 @@ TEST(C_ConsumerConfigurationTest, testCApiConfig) {
pulsar_consumer_configuration_set_auto_ack_oldest_chunked_message_on_queue_full(consumer_conf, 1);
ASSERT_EQ(pulsar_consumer_configuration_is_auto_ack_oldest_chunked_message_on_queue_full(consumer_conf),
1);

pulsar_consumer_configuration_set_start_message_id_inclusive(consumer_conf, 1);
ASSERT_EQ(pulsar_consumer_configuration_is_start_message_id_inclusive(consumer_conf), 1);
}