[Bug Fix][KeySharedPolicy] Fixed bug where KeySharedPolicy::setStickyRanges duplicated ranges.

[hyperevo]

*[fix] Fixed bug where KeySharedPolicy::setStickyRanges appended duplicate ranges to KeySharedPolicy->ranges. The for loop was nested when it shouldn't have been nested.

This fixes the issue #241

*Added a test that checks to see if the KeySharedPolicy->ranges variable is set as expected after calling KeySharedPolicy::setStickyRanges

*Added overloaded KeySharedPolicy::setStickyRanges function that takes the StickyRanges vector. This is convenient in case a developer wants to provide a vector. It is also required for adding KeySharedPolicy to the python pulsar client which uses pybind11. std::initializer_list type conversion is not supported with pybind11. See pybind/pybind11#1302 (comment)
I am in the process of adding support for KeySharedPolicy to the python-pulsar-client and will submit a pr soon.

*Added a test that checks to see if the KeySharedPolicy->ranges variable is the same when using the two different overloaded KeySharedPolicy::setStickyRanges functions.

Modifications

Moved for loop in KeySharedPolicy::setStickyRanges to unnested location to eliminate duplicate vector entries.

Added simple overloaded version of the same function that a parameter of type StickyRanges in addition to existing function that takes a parameter of type std::initializer_list

Added two new tests in KeySharedPolicyTest.cc to validate the changes.

Verifying this change

This change added tests and can be verified as follows:

Added two new tests in KeySharedPolicyTest.cc to validate the changes.

Documentation

• doc-required
  (Your PR needs to update docs and you will update later)

• [ *] doc-not-needed
  (Please explain why)
  Bug fix did not change functionality in any new ways that are not covered by existing documentation.

• doc
  (Your PR contains doc changes)

• doc-complete
  (Docs have been already added)

[hyperevo]

Here is the pulsar python client pr that is dependent on this pr apache/pulsar-client-python#109

[shibd]

@hyperevo Please fix the code format.

You can use ./build-support/docker-format.sh

[BewareMyPower]

Please fix the code format as well

[hyperevo]

Thanks for reviewing! I made the changes requested and ran ./build-support/docker-format.sh to format correctly in the latest commit.

[BewareMyPower]

Please fix the build error:

/home/runner/work/pulsar-client-cpp/pulsar-client-cpp/lib/KeySharedPolicy.cc: In member function ‘pulsar::KeySharedPolicy& pulsar::KeySharedPolicy::setStickyRanges(std::initializer_list<std::pair<int, int> >)’:
/home/runner/work/pulsar-client-cpp/pulsar-client-cpp/lib/KeySharedPolicy.cc:54:47: error: expected primary-expression before ‘v’
   54 |     return this->setStickyRanges(StickyRanges v(ranges));

[hyperevo]

Please fix the build error:

/home/runner/work/pulsar-client-cpp/pulsar-client-cpp/lib/KeySharedPolicy.cc: In member function ‘pulsar::KeySharedPolicy& pulsar::KeySharedPolicy::setStickyRanges(std::initializer_list<std::pair<int, int> >)’:
/home/runner/work/pulsar-client-cpp/pulsar-client-cpp/lib/KeySharedPolicy.cc:54:47: error: expected primary-expression before ‘v’
   54 |     return this->setStickyRanges(StickyRanges v(ranges));

This should be fixed now.