[feat] Support pattern subscribe non-persistent topic.#207
Merged
shibd merged 2 commits intoapache:mainfrom Mar 31, 2023
Merged
[feat] Support pattern subscribe non-persistent topic.#207shibd merged 2 commits intoapache:mainfrom
shibd merged 2 commits intoapache:mainfrom
Conversation
Member
Great idea. Are there any other contexts that we need to use RegexSubscriptionMode except for this case in the Java client? Would it be possible also apply this solution to the Java client? |
Member
Author
There is no other case using
Yes, I'll start an email to discuss this. |
Member
Author
6498f13 to
5ac904e
Compare
Member
Author
|
After, we need to add a RegexSubscriptionMode config. PTAL. |
BewareMyPower
approved these changes
Mar 29, 2023
09e2871 to
6f93009
Compare
6f93009 to
8607653
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue: #204
Motivation
The current default only lookup persistent topics on the namespace, We need to add
RegexSubscriptionModeto control the lookup topics type.The Java client relate impl refer: apache/pulsar#2025
Modifications
RegexSubscriptionModeto support pattern subscribeall/persistent only/non-persistent-onlytopic.Verifying this change
TopicNameTest.testRemoveDomainto cover the newly addedTopicName::removeDomainmethod.TopicNameTest.testContainsDomainto cover the newly addedTopicName::containsDomainmethod.LookupServiceTest.basicGetNamespaceTopicsmethod to cover more get topics cases.ConsumerTest.testPatternSubscribeTopicto cover use pattern subscribe topersistent topic,non-persistent topic, andall topic.Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)