[feat] Support auto download schema when create producer.#157
Merged
BewareMyPower merged 4 commits intoapache:mainfrom Jan 19, 2023
Merged
[feat] Support auto download schema when create producer.#157BewareMyPower merged 4 commits intoapache:mainfrom
BewareMyPower merged 4 commits intoapache:mainfrom
Conversation
4 tasks
Member
Author
|
Job failure seems to have a flaky test, can help review and rerun the job? @BewareMyPower |
BewareMyPower
requested changes
Jan 18, 2023
BewareMyPower
requested changes
Jan 18, 2023
BewareMyPower
approved these changes
Jan 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If a schema exists in a topic, but the producer does not know it. He still wanted to send data to the topic. (The scenario in which the DLQ sends a message: Please refer #139 [Verifying this change][5])
Modifications
autoDownloadSchemaparam, try to get the schema of that topic and use it.getSchemaonLookupService(HTTP and Binary).Verifying this change
LookupServiceTestunit test to covergetSchemalogic.SchemaTest.testAutoDownloadSchemaunit test to cover creating producer success when the topic has a schema.Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)