Skip to content

Comments

[fix] Fix log for connection disconnected expectedly#156

Merged
BewareMyPower merged 3 commits intoapache:mainfrom
RobertIndie:cnx-err
Dec 28, 2022
Merged

[fix] Fix log for connection disconnected expectedly#156
BewareMyPower merged 3 commits intoapache:mainfrom
RobertIndie:cnx-err

Conversation

@RobertIndie
Copy link
Member

Fixes #140

Motivation

When running produce and consume, and the client calls close, it
shows ConnectError in the close method

[[127.0.0.1:43644](http://127.0.0.1:43644/) -> [127.0.0.1:6650](http://127.0.0.1:6650/)] Connection closed with
ConnectError

Modifications

  • Show Connection disconnected just like the java client did instead of ConnectError when the client disconnect successfully.
  • Add error log for unexpected closed connection.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@RobertIndie RobertIndie added this to the 3.2.0 milestone Dec 23, 2022
@RobertIndie RobertIndie self-assigned this Dec 23, 2022
@RobertIndie RobertIndie marked this pull request as draft December 23, 2022 11:22
@RobertIndie RobertIndie marked this pull request as ready for review December 26, 2022 11:35
@BewareMyPower BewareMyPower merged commit d04ba21 into apache:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] The log shows ConnectError when closing the client

3 participants