[fix] Fix log for connection disconnected expectedly#156
Merged
BewareMyPower merged 3 commits intoapache:mainfrom Dec 28, 2022
Merged
[fix] Fix log for connection disconnected expectedly#156BewareMyPower merged 3 commits intoapache:mainfrom
BewareMyPower merged 3 commits intoapache:mainfrom
Conversation
shibd
reviewed
Dec 26, 2022
shibd
approved these changes
Dec 28, 2022
BewareMyPower
approved these changes
Dec 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140
Motivation
When running produce and consume, and the client calls close, it
shows
ConnectErrorin the close methodModifications
Connection disconnectedjust like the java client did instead ofConnectErrorwhen the client disconnect successfully.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)