Fix segmentation fault during the destruction of ConsumerImpl#121
Merged
BewareMyPower merged 1 commit intoapache:mainfrom Nov 22, 2022
Merged
Conversation
### Motivation When I ran the tests of Python wrapper in my local env, I observed a segmentation fault. See the key stacktrace: ``` #3 0x00007ffff6d742c5 in std::unique_lock<std::mutex>::lock() () from /usr/local/lib/python3.8/dist-packages/_pulsar.cpython-38-x86_64-linux-gnu.so #4 0x00007ffff6d72523 in std::unique_lock<std::mutex>::unique_lock(std::mutex&) () from /usr/local/lib/python3.8/dist-packages/_pulsar.cpython-38-x86_64-linux-gnu.so #5 0x00007ffff67de193 in pulsar::ClientImpl::newRequestId (this=0x0) at /home/xyz/github.com/apache/pulsar-client-cpp/lib/ClientImpl.cc:644 #6 0x00007ffff685d2c2 in pulsar::ConsumerImpl::~ConsumerImpl (this=0x7fff9800f9e0, __in_chrg=<optimized out>) at /home/xyz/github.com/apache/pulsar-client-cpp/lib/ConsumerImpl.cc:116 ``` In the destructor of `ConsumerImpl`, `client->newRequestId` might be called. However, `client` might be a null pointer because it's returned by `std::weak_ptr::lock()`. ### Modifications Add null check to avoid the segfault.
Contributor
Author
|
@RobertIndie PTAL first since you are the release manager of 3.1.0. I will depend on C++ client 3.1.0 on Python client. It's hard to reproduce because there is still something wrong with the Python client in my local env and I'm not sure why the current branch cannot expose this bug. |
tisonkun
approved these changes
Nov 22, 2022
Demogorgon314
approved these changes
Nov 22, 2022
RobertIndie
approved these changes
Nov 22, 2022
shibd
approved these changes
Nov 22, 2022
RobertIndie
pushed a commit
that referenced
this pull request
Nov 23, 2022
### Motivation When I ran the tests of Python wrapper in my local env, I observed a segmentation fault. See the key stacktrace: ``` #3 0x00007ffff6d742c5 in std::unique_lock<std::mutex>::lock() () from /usr/local/lib/python3.8/dist-packages/_pulsar.cpython-38-x86_64-linux-gnu.so #4 0x00007ffff6d72523 in std::unique_lock<std::mutex>::unique_lock(std::mutex&) () from /usr/local/lib/python3.8/dist-packages/_pulsar.cpython-38-x86_64-linux-gnu.so #5 0x00007ffff67de193 in pulsar::ClientImpl::newRequestId (this=0x0) at /home/xyz/github.com/apache/pulsar-client-cpp/lib/ClientImpl.cc:644 #6 0x00007ffff685d2c2 in pulsar::ConsumerImpl::~ConsumerImpl (this=0x7fff9800f9e0, __in_chrg=<optimized out>) at /home/xyz/github.com/apache/pulsar-client-cpp/lib/ConsumerImpl.cc:116 ``` In the destructor of `ConsumerImpl`, `client->newRequestId` might be called. However, `client` might be a null pointer because it's returned by `std::weak_ptr::lock()`. ### Modifications Add null check to avoid the segfault.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When I ran the tests of Python wrapper in my local env, I observed a segmentation fault. See the key stacktrace:
In the destructor of
ConsumerImpl,client->newRequestIdmight be called. However,clientmight be a null pointer because it's returned bystd::weak_ptr::lock().Modifications
Add null check to avoid the segfault.