[Improve][Build] Use pulsar client as a submodule for C++ projects#115
Merged
BewareMyPower merged 2 commits intoapache:mainfrom Nov 14, 2022
fregate:as-submodule
Merged
[Improve][Build] Use pulsar client as a submodule for C++ projects#115BewareMyPower merged 2 commits intoapache:mainfrom fregate:as-submodule
BewareMyPower merged 2 commits intoapache:mainfrom
fregate:as-submodule
Conversation
Contributor
Author
|
change base branch |
BewareMyPower
requested changes
Nov 11, 2022
Contributor
BewareMyPower
left a comment
There was a problem hiding this comment.
Could you change the target branch from branch-3.0 to master so that CI will be run?
Contributor
|
It probably needs to be rebased on top of |
Contributor
Author
|
I can't build Release tag build correctly configure command: CMake output: |
Contributor
Author
Change CMakeLists to build pulsar client (and tests) as a submodule for C++ projects Minimal example here: #100
Contributor
Author
|
Rebased |
BewareMyPower
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100
Motivation
If your project builds through CMake and you try to add pulsar-client in some directory for build with whole project (i.e. third-party submodule) you can't do this because pulsar-client CMake uses CMAKE_*_DIR for configure, and this variable always related to top-level project.
Modifications
Change CMAKE_(SOURCES|BINARY)DIR to PROJECT*_DIR for library and tests
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-neededBuild process already covered in documentation
doc(Your PR contains doc changes)
doc-completeBuild process already covered in documentation