-
Notifications
You must be signed in to change notification settings - Fork 31
[Build] Add GitHub Actions build for pulsar-adapters #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eolivelli
merged 15 commits into
apache:master
from
lhotari:lh-fix-github-actions-build
Jun 17, 2021
Merged
[Build] Add GitHub Actions build for pulsar-adapters #19
eolivelli
merged 15 commits into
apache:master
from
lhotari:lh-fix-github-actions-build
Jun 17, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Some details of integration test failures: |
This reverts commit f9c5147.
eolivelli
approved these changes
Jun 16, 2021
Contributor
eolivelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
let's merge this patch and then fix the tests.
with this patch we will have CI feedback
Contributor
|
@codelipenghui we should merge this patch ASAP, in order to prevent problems like #21 |
codelipenghui
approved these changes
Jun 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11 #12
Motivation
GitHub Actions build is not up-to-date for pulsar-adapters.
Modifications
Open issues
Consumer connect fail! consumer state:ConnectingandCannot seek on a partition where we are not subscribed