(#8491) - Fix $regex and $ne within $or operator#8493
Merged
garethbowen merged 4 commits intoapache:masterfrom Aug 22, 2022
Merged
(#8491) - Fix $regex and $ne within $or operator#8493garethbowen merged 4 commits intoapache:masterfrom
garethbowen merged 4 commits intoapache:masterfrom
Conversation
Contributor
|
Original issue: #8491 |
garethbowen
requested changes
Aug 21, 2022
Contributor
garethbowen
left a comment
garethbowen
left a comment
There was a problem hiding this comment.
LGTM. Just one small readability change and I'll sign off on it. Thanks!
Comment on lines
324
to
326
| var fields = Object.keys(selector); | ||
| for (var i = 0; i < fields.length; i++) { | ||
| var field = fields[i]; |
Contributor
There was a problem hiding this comment.
It'd be better to use a forEach loop here...
Suggested change
| var fields = Object.keys(selector); | |
| for (var i = 0; i < fields.length; i++) { | |
| var field = fields[i]; | |
| Object.keys(selector).forEach(function (field) { | |
| ... | |
| }); |
Contributor
Author
There was a problem hiding this comment.
Agreed! The forEach is more of my style, I must have been trying to replicate code style from above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.