-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Added null check for value in getFieldFromDoc in pouchdb selector core utils #8027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@daleharvey |
|
hello @t-cho1 I am terribly sorry for the time that it has taken to get your contribution reviewed. As you have seen, tests has ben migrated to GitHub Actions. I wonder if you can get the latest changes and apply your contribution and check should tests passed? Thanks. |
|
Hey @t-cho1 , could you rebase from master? It will allow me to trigger Github actions. Thanks! |
|
@t-cho1 @AlbaHerrerias any chance to get this reviewed? |
Add semicolon
|
Assumption is wrong; this would break pouchdb. |
Sometimes
valuewould be undefined, so in the for loop, it would be looking forvalue[key], which spits outCannot read property <property> of undefined