Skip to content

Conversation

@t-cho1
Copy link

@t-cho1 t-cho1 commented Mar 10, 2020

Screen Shot 2020-03-10 at 1 38 34 PM
Sometimes value would be undefined, so in the for loop, it would be looking for value[key], which spits out Cannot read property <property> of undefined

@stale
Copy link

stale bot commented May 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 9, 2020
@stale stale bot closed this May 16, 2020
@gaodeng
Copy link

gaodeng commented Aug 12, 2021

@daleharvey
Can you help merge this PR ?

@dheimoz dheimoz reopened this Aug 12, 2021
@dheimoz
Copy link

dheimoz commented Oct 19, 2021

hello @t-cho1 I am terribly sorry for the time that it has taken to get your contribution reviewed. As you have seen, tests has ben migrated to GitHub Actions. I wonder if you can get the latest changes and apply your contribution and check should tests passed?

Thanks.

@AlbaHerrerias
Copy link
Contributor

Hey @t-cho1 , could you rebase from master? It will allow me to trigger Github actions. Thanks!

@rasgo-cc
Copy link
Contributor

rasgo-cc commented Apr 3, 2023

@t-cho1 @AlbaHerrerias any chance to get this reviewed?
getFieldFromDoc is still crashing whenever the doc is null / undefined

@garethbowen
Copy link
Contributor

@rasgo-cc It seems like @t-cho1 is not responding so nobody can update the PR to run the GH actions which is required to merge. Would you mind creating a new PR from master which this change? Then we can close this one.

lucidNTR added a commit to cloudless-hq/pouchdb that referenced this pull request May 1, 2023
lucidNTR added a commit to cloudless-hq/pouchdb that referenced this pull request May 1, 2023
@SourceR85
Copy link
Contributor

Assumption is wrong; this would break pouchdb.
Since it needs more work and the author isn't active, I suggest to abandon this patch.

@SourceR85 SourceR85 closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants