[PROTOTYPE] Event listeners using Jakarta Events #921
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
reviewed
Feb 7, 2025
| @@ -1256,6 +1262,8 @@ public void doRefresh() { | |||
|
|
|||
| @Override | |||
| public void doCommit(TableMetadata base, TableMetadata metadata) { | |||
| eventEmitter.fire(new BeforeTableCommitEvent(base, metadata)); | |||
There was a problem hiding this comment.
One potential problem with the Jakarta events approach is that the firing is synchronous. This call can potentially take a long time to complete, depending on how many observers are subscribed, and how long they take to process the event.
There is a fireAsync method, I think it would be more appropriate.
But in general, maybe using a more robust event bus like the one provided by Vert.x would be a better idea.
There was a problem hiding this comment.
Vert.x event buses sound interesting, but I haven't used them before. Do you already have a sense of the tradeoffs or would you unequivocally suggest using them?
|
Closed in favor of #922 |
github-project-automation
bot
moved this from PRs In Progress
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://lists.apache.org/thread/03yz5wolkvy8l7rbcwjnqdq1bl8p065v for context