Allow custom access token generation in integration test env #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polaris allows running the integration test suite against an external (managed) server. This change further enables customizing access tokens for these tests according to the test env. needs.
dimas-b
requested review from
adutra,
ashvina,
eric-maynard,
jackye1995,
jbonofre,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
flyrain and
ebyhr
as code owners
dimas-b
added a commit
to dimas-b/polaris
that referenced
this pull request
Jan 20, 2025
Obtain access tokens from `PolarisAccessManager` (apache#789) before starting Spark sessions as opposed to passing client ID/secret to Spark and relying on the Iceberg REST Client to obtain access tokens. This makes all "blackbox" integration tests obtain access tokens the same way.
dimas-b
added a commit
that referenced
this pull request
Jan 21, 2025
Obtain access tokens from `PolarisAccessManager` (#789) before starting Spark sessions as opposed to passing client ID/secret to Spark and relying on the Iceberg REST Client to obtain access tokens. This makes all "blackbox" integration tests obtain access tokens the same way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polaris allows running the integration test suite against an external (managed) server.
This change further enables customizing access tokens for these tests according to the test env. needs.