Ability to run quarkusRun on polaris-quarkus-server #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a task named `polarisServerRun` to make it easier to run a Polaris server with Gradle. Note: the server is started with `prod` profile. Also adds a note about the binary distribution and how to unpack and run it.
adutra
requested review from
ashvina,
dimas-b,
eric-maynard,
jackye1995,
jbonofre,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
flyrain and
ebyhr
as code owners
snazy
reviewed
Jan 15, 2025
quarkus/server/build.gradle.kts
Outdated
| @@ -61,6 +61,12 @@ tasks.named("distZip") { dependsOn("quarkusBuild") } | |||
|
|
|||
| tasks.named("distTar") { dependsOn("quarkusBuild") } | |||
|
|
|||
| tasks.named("javadoc") { enabled = false } | |||
There was a problem hiding this comment.
Better add a dummy java file in there. When we eventually publish Maven artifacts, the publication will fail without a javadoc and a sources jar.
There was a problem hiding this comment.
I see you added a package-info.java - that should be enough.
Maybe you have to tell javadoc to not fail on errors (different attribute)
snazy
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a task named
polarisServerRunto make it easier to run a Polaris server with Gradle. Note: the server is started withprodprofile.Also adds a note about the binary distribution and how to unpack and run it.