Preserve catalog storage names in setup round trips - #5345
Open
mattfaltyn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
polaris setup exportomitted a catalog's optionalstorageName, and the applypath could not restore it. A successful backup, migration, or bootstrap round
trip therefore changed credential selection when
RESOLVE_CREDENTIALS_BY_STORAGE_NAMEwas enabled.This change preserves the field across export and apply for every supported
storage type. Existing setup files remain compatible because
storage_nameisoptional and defaults to
Nonewhen absent.Fixes #5344.
Changes
storageNameasstorage_namein setup YAML.builders.
recreated storage name.
Validation
JAVA_HOME=/private/tmp/polaris-jdk21/Contents/Home ./gradlew format compileAll— passed (981 actionable tasks).
JAVA_HOME=/private/tmp/polaris-jdk21/Contents/Home make client-regenerate— passed.
JAVA_HOME=/private/tmp/polaris-jdk21/Contents/Home make client-unit-test— passed (193 tests).
make client-lint— passed (trailing whitespace, EOF, debug statements,Ruff check/format, MyPy).
make client-license-check— passed.reference-setup-config.yamlandgit diff --check— passed.Checklist
CHANGELOG.mdunder Unreleased / Fixes.AI assistance
Codex assisted with repository analysis, implementation, and validation. The
contributor reviewed the resulting issue, code, tests, documentation, and PR
description.